feat(integrations): acs integration example#3102
Conversation
|
|
@rahulbhadja is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 8 files
Confidence score: 3/5
- There is a concrete regression risk around the new
beginSendflow: bothapps/docs/integrations/azure-communication-email.mdxandexamples/azure-communication-email/src/index.tsxomit an explicit production credential permission check, which could lead to failed sends or misconfigured deployments. - I’m scoring this as moderate merge risk because the top findings are medium-high severity (7/10) with high confidence (9/10), and they affect guidance and sample implementation that users are likely to copy.
examples/azure-communication-email/tsconfig.jsonis a smaller but real correctness issue: missing Node ambient types while usingprocess.envcan cause type errors and confusion in local builds.- Pay close attention to
apps/docs/integrations/azure-communication-email.mdx,examples/azure-communication-email/src/index.tsx, andexamples/azure-communication-email/tsconfig.json- permission-check guidance forbeginSendand Node typing should be fixed before broad adoption.
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
gabrielmfern
left a comment
gabrielmfern
left a comment
There was a problem hiding this comment.
it should be using react-email not @react-email/components
gabrielmfern
changed the title
- Added documentation for Azure Communication Email integration. - Created example for sending emails using Azure Communication Email. - Updated integrations list and snippets to include Azure Communication Email.
gabrielmfern
force-pushed
the
feat/azure-email-communication-example
branch
from
7ac0008 to
42c98c8
Compare
Signed-off-by: gabriel miranda <gabriel@resend.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: gabriel miranda <gabriel@resend.com>
Signed-off-by: gabriel miranda <gabriel@resend.com>
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Auto-approved: This PR adds an Azure Communication Email integration example, documentation, and navigation links, with no changes to core library or production logic, making it low-risk and safe to auto-approve.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: This PR adds a new Azure Communication Email integration example along with documentation, following the same pattern as existing integrations; no core library code or production paths are modified, so the blast radius is minimal and the risk is low.
Re-trigger cubic
|
thanks @gabrielmfern for reviewing, was gonna add the changes today 👍🏼 |
gabrielmfern
changed the title
3 participants
Summary
Adds new Azure Communication Email integration example to React Email.
Changes
Notes
@azure/communication-emailAZURE_EMAIL_CONNECTION_STRINGSummary by cubic
Adds an Azure Communication Email integration example and docs. Lets users render templates with
react-emailand send via@azure/communication-emailusingAZURE_EMAIL_CONNECTION_STRING.examples/azure-communication-emailusing unifiedreact-email(fixed imports), pinned deps, and Node types; shows render +EmailClient.beginSendwithpollUntilDone.senderAddress.Written for commit 03bd5c5. Summary will update on new commits. Review in cubic